fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jroweboy <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...
Date Thu, 12 May 2016 17:21:44 GMT
Github user jroweboy commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/110#discussion_r63060689
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/WorkingDays.java
---
    @@ -74,6 +78,8 @@ public Boolean getExtendTermForDailyRepayments(){
             return this.extendTermForDailyRepayments;
         }
     
    +    public Boolean getExtendTermForRepaymentsOnHolidays() { return this.extendTermForRepaymentsOnHolidays;
}
    +
         public Map<String, Object> update(final JsonCommand command) {
    --- End diff --
    
    I apologize that I didn't mention the fact that I was asking for feedback on how I added
the changes. That said, I will add in the rest of the backend changes in order to make this
an acceptable PR when I get a little extra time. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message