fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adi Raju" <adi.r...@confluxtechnologies.com>
Subject RE: Review of Pull Request from James Rowe
Date Fri, 13 May 2016 05:36:48 GMT
Hi James,

 

Thanks for the clarifications.

Going forward I would suggest starting a discussion on dev@fineract.incubator.apache.org <mailto:dev@fineract.incubator.apache.org>
 to take decisions on a solution rather than taking PR path.

 

Thanks,

Adi

 

From: James Rowe [mailto:jroweboy@gmail.com] 
Sent: 12 May 2016 22:42
To: Adi Raju <adi.raju@confluxtechnologies.com>
Cc: Ed Cable <edcable@mifos.org>; dev@fineract.incubator.apache.org; Austin H <austin@haedrian.io>;
Nathan McClellan <nathan@mentorsinternational.org>
Subject: Re: Review of Pull Request from James Rowe

 

Hello Adi! Thank you for the review. When I was writing this code, I knew that the code is
not a full solution, and I wouldn't expect it to be pulled in it current state. But you are
right, I was planning on writing that in the comments to let people know this! I wanted to
make sure that the way that I was handling the change was a good idea, and if it was, I would
move forward to adding the rest of the necessary changes to make it a complete pull request.
I will update the comments to reflect this. Thanks again for the review.

James

 

On Thu, May 12, 2016 at 4:50 AM, Adi Raju <adi.raju@confluxtechnologies.com <mailto:adi.raju@confluxtechnologies.com>
> wrote:

I have provided high level comments on the PR.

PR cannot be taken in as is.

I will ask the fellow community members to provide more comments on the core part of the solution.

 

Regards,

Adi

 

From: Ed Cable [mailto:edcable@mifos.org <mailto:edcable@mifos.org> ] 
Sent: 11 May 2016 03:58
To: dev@fineract.incubator.apache.org <mailto:dev@fineract.incubator.apache.org> ; Adi
Raju <adi.raju@confluxtechnologies.com <mailto:adi.raju@confluxtechnologies.com>
>
Cc: James Rowe <jroweboy@gmail.com <mailto:jroweboy@gmail.com> >; Austin H <austin@haedrian.io
<mailto:austin@haedrian.io> >; Nathan McClellan <nathan@mentorsinternational.org
<mailto:nathan@mentorsinternational.org> >
Subject: Review of Pull Request from James Rowe

 

Hi Fineract devs,

 

I wanted to make sure you saw the incoming pull request from James Rowe. It's a fix for holidays
that's needed by customer of theirs in the Philippines that is needed in the latest stable
release.

 

Adi, this will ultimately be something we'll need to ensure is in our Mifos X distribution
of Fineract.

 

Ed 


 

-- 

Ed Cable

Director of Community Programs, Mifos Initiative

edcable@mifos.org <https://web.chilipiper.com/link/mifos.org/57325ffae4b02bbec5bc5b8b?link=bWFpbHRvJTNBZWRjYWJsZSU0MG1pZm9zLm9yZw==>
 | Skype: edcable | Mobile: +1.484.477.8649 <tel:%2B1.484.477.8649> 

 

Collectively Creating a World of 3 Billion Maries | http://mifos.org <https://web.chilipiper.com/link/mifos.org/57325ffae4b02bbec5bc5b8b?link=aHR0cCUzQSUyRiUyRm1pZm9zLm9yZw==>
  <https://web.chilipiper.com/link/mifos.org/57325ffae4b02bbec5bc5b8b?link=aHR0cCUzQSUyRiUyRmZhY2Vib29rLmNvbSUyRm1pZm9z>
  <https://web.chilipiper.com/link/mifos.org/57325ffae4b02bbec5bc5b8b?link=aHR0cCUzQSUyRiUyRnd3dy50d2l0dGVyLmNvbSUyRm1pZm9z>


 

  <https://web.chilipiper.com/track/mifos.org/57325ffae4b02bbec5bc5b8b.png> 

 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message