Return-Path: X-Original-To: apmail-fineract-dev-archive@minotaur.apache.org Delivered-To: apmail-fineract-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E579618593 for ; Tue, 19 Apr 2016 12:42:54 +0000 (UTC) Received: (qmail 58086 invoked by uid 500); 19 Apr 2016 12:42:54 -0000 Delivered-To: apmail-fineract-dev-archive@fineract.apache.org Received: (qmail 58051 invoked by uid 500); 19 Apr 2016 12:42:54 -0000 Mailing-List: contact dev-help@fineract.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.incubator.apache.org Delivered-To: mailing list dev@fineract.incubator.apache.org Received: (qmail 58039 invoked by uid 99); 19 Apr 2016 12:42:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 12:42:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 218B4C0BC3 for ; Tue, 19 Apr 2016 12:42:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id x9LcKt3797wV for ; Tue, 19 Apr 2016 12:42:52 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id F38135F241 for ; Tue, 19 Apr 2016 12:42:51 +0000 (UTC) Received: (qmail 58025 invoked by uid 99); 19 Apr 2016 12:42:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 12:42:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 28D2DDFE04; Tue, 19 Apr 2016 12:42:51 +0000 (UTC) From: pramodn02 To: dev@fineract.incubator.apache.org Reply-To: dev@fineract.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-fineract pull request: FINERACT-60 : Interest compoundin... Content-Type: text/plain Message-Id: <20160419124251.28D2DDFE04@git1-us-west.apache.org> Date: Tue, 19 Apr 2016 12:42:51 +0000 (UTC) Github user pramodn02 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/63#discussion_r60222661 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java --- @@ -191,11 +192,13 @@ @Embedded private LoanProductRelatedDetail loanRepaymentScheduleDetail; - @Column(name = "repayment_frequency_nth_day_enum", nullable = true) - private Integer repaymentFrequencyNthDayType; - - @Column(name = "repayment_frequency_day_of_week_enum", nullable = true) - private Integer repaymentFrequencyDayOfWeekType; + /* --- End diff -- please remove all commented code from the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---