fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pramodn02 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request: 254:In tranche loans, if repaymen...
Date Mon, 25 Apr 2016 09:28:07 GMT
Github user pramodn02 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/76#discussion_r60884862
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanTermVariationsDataWrapper.java
---
    @@ -55,26 +55,34 @@ public LoanTermVariationsDataWrapper(final List<LoanTermVariationsData>
exceptio
             dueDateIterator = this.dueDateVariation.listIterator();
         }
     
    -    public boolean hasVariation(final LocalDate date) {
    +    public boolean hasVariation(final LocalDate date, final Boolean isChangeEmiIfRepaymentDateSameAsDisbursementDateEnabled)
{
             ListIterator<LoanTermVariationsData> iterator = this.iterator;
    -        return hasNext(date, iterator);
    +        return hasNext(date, iterator, isChangeEmiIfRepaymentDateSameAsDisbursementDateEnabled);
         }
     
    -    private boolean hasNext(final LocalDate date, ListIterator<LoanTermVariationsData>
iterator) {
    +    private boolean hasNext(final LocalDate date, ListIterator<LoanTermVariationsData>
iterator, 
    +            final Boolean isChangeEmiIfRepaymentDateSameAsDisbursementDateEnabled) {
             boolean hasVariation = false;
             if (iterator.hasNext()) {
                 LoanTermVariationsData loanTermVariationsData = iterator.next();
    -            if (!loanTermVariationsData.getTermApplicableFrom().isAfter(date)) {
    -                hasVariation = true;
    +            if (!isChangeEmiIfRepaymentDateSameAsDisbursementDateEnabled) {
    --- End diff --
    
    you can modify the effective date of emi amount  with the configuration.. no need to check
all the time


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message