Return-Path: 
 <dev-return-492-apmail-fineract-dev-archive=fineract.apache.org@fineract.incubator.apache.org>
X-Original-To: apmail-fineract-dev-archive@minotaur.apache.org
Delivered-To: apmail-fineract-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CC3CE18808
	for <apmail-fineract-dev-archive@minotaur.apache.org>;
 Tue, 22 Mar 2016 03:46:51 +0000 (UTC)
Received: (qmail 62451 invoked by uid 500); 22 Mar 2016 03:46:51 -0000
Delivered-To: apmail-fineract-dev-archive@fineract.apache.org
Received: (qmail 62410 invoked by uid 500); 22 Mar 2016 03:46:51 -0000
Mailing-List: contact dev-help@fineract.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@fineract.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@fineract.incubator.apache.org>
List-Post: <mailto:dev@fineract.incubator.apache.org>
List-Id: <dev.fineract.incubator.apache.org>
Reply-To: dev@fineract.incubator.apache.org
Delivered-To: mailing list dev@fineract.incubator.apache.org
Received: (qmail 62394 invoked by uid 99); 22 Mar 2016 03:46:51 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO
 spamd2-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 03:46:51 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org)
 with ESMTP id C0E401A12BA
	for <dev@fineract.apache.org>; Tue, 22 Mar 2016 03:46:50 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.021
X-Spam-Level: 
X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.001] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new,
 port 10024)
	with ESMTP id Y03VY_ENwsSz for <dev@fineract.apache.org>;
	Tue, 22 Mar 2016 03:46:50 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP
 id 118365FB08
	for <dev@fineract.incubator.apache.org>;
 Tue, 22 Mar 2016 03:46:48 +0000 (UTC)
Received: (qmail 62390 invoked by uid 99); 22 Mar 2016 03:46:48 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 03:46:48 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id D52D4DFA42; Tue, 22 Mar 2016 03:46:47 +0000 (UTC)
From: rajuan <git@git.apache.org>
To: dev@fineract.incubator.apache.org
Reply-To: dev@fineract.incubator.apache.org
References: <git-pr-38-incubator-fineract@git.apache.org>
In-Reply-To: <git-pr-38-incubator-fineract@git.apache.org>
Subject: [GitHub] incubator-fineract pull request: Provision for notes while
 editing...
Content-Type: text/plain
Message-Id: <20160322034647.D52D4DFA42@git1-us-west.apache.org>
Date: Tue, 22 Mar 2016 03:46:47 +0000 (UTC)

Github user rajuan commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/38#discussion_r56933937
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/note/domain/NoteRepository.java ---
    @@ -41,5 +41,6 @@
     
         List<Note> findBySavingsAccountId(Long savingAccountId);
     
    +    Note findByLoanTransactionId(Long loanTransactionId); 
    --- End diff --
    
    By data design there can be multiple notes for a single transaction id.... this API cannot return single Note


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---