fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nazeer1100126 <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request: Capturing Time
Date Wed, 30 Mar 2016 05:29:20 GMT
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/56#discussion_r57838529
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/calendar/domain/Calendar.java
---
    @@ -387,7 +395,13 @@ public static Calendar fromJson(final JsonCommand command) {
                 actualChanges.put(secondRemindarParamName, newValue);
                 this.secondReminder = newValue;
             }
    -
    +        
    +        if (command.isChangeInStringParameterNamed(CALENDAR_SUPPORTED_PARAMETERS.MEETING_TIME.getValue(),
this.meetingtime.toString())) {
    +            final String newValue = command.stringValueOfParameterNamed(CALENDAR_SUPPORTED_PARAMETERS.MEETING_TIME.getValue());
    +            actualChanges.put(CALENDAR_SUPPORTED_PARAMETERS.MEETING_TIME.getValue(),
newValue);
    +            this.meetingtime =Time.valueOf(StringUtils.defaultIfEmpty(newValue, null));
    --- End diff --
    
    Don't use java.sql.Time to parse time data. Please add a method in JsonParserHelper to
get the time object. Please have a look how LocalDate is parsed in the same file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message