fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rajuan <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request: FINERACT-76 adding fund source to...
Date Tue, 22 Mar 2016 05:44:34 GMT
Github user rajuan commented on the pull request:

    https://github.com/apache/incubator-fineract/pull/41#issuecomment-199647050
  
    As of now, Income account client charges are defined while defining the charges. We would
suggest the same place to add advanced GLaccount mappings for different payment types as well.
Solution as provided in PR, in my opinion, splits the way GL accounts mappings are defined
across portfolio as of now. Also allowing to define fund source account id at payment type
definition could mislead the user into believing that the definition is valid across the portfolios.
In the future also new use cases could come up which might make this solution non-extendable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message