fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rajuan <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request: Provision for notes while editing...
Date Tue, 22 Mar 2016 03:50:17 GMT
Github user rajuan commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/38#discussion_r56934197
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
---
    @@ -1286,11 +1303,13 @@ public String accountTransferSchema() {
                         + " fromtran.description as fromTransferDescription,"
                         + " totran.id as toTransferId, totran.is_reversed as toTransferReversed,"
                         + " totran.transaction_date as toTransferDate, totran.amount as toTransferAmount,"
    -                    + " totran.description as toTransferDescription "
    +                    + " totran.description as toTransferDescription ,"
    +                    + " usernote.note as note"
                         + " from m_loan l join m_loan_transaction tr on tr.loan_id = l.id"
                         + " join m_currency rc on rc.`code` = l.currency_code "
                         + " left join m_account_transfer_transaction fromtran on fromtran.from_loan_transaction_id
= tr.id "
    -                    + " left join m_account_transfer_transaction totran on totran.to_loan_transaction_id
= tr.id ";
    +                    + " left join m_account_transfer_transaction totran on totran.to_loan_transaction_id
= tr.id "
    +                    + "left join m_note usernote on usernote.loan_transaction_id=tr.id";
    --- End diff --
    
    What is the use of this join when the attribute is not read in mapper?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message