fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rajuan <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request: adding organisation start in glob...
Date Mon, 29 Feb 2016 04:27:57 GMT
Github user rajuan commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/12#discussion_r54368307
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
---
    @@ -1566,15 +1571,20 @@ public LoanTermVariationsData mapRow(final ResultSet rs, @SuppressWarnings("unus
                     .append(" where ((ls.fee_charges_amount <> if(ls.accrual_fee_charges_derived
is null,0, ls.accrual_fee_charges_derived))")
                     .append(" or ( ls.penalty_charges_amount <> if(ls.accrual_penalty_charges_derived
is null,0,ls.accrual_penalty_charges_derived))")
                     .append(" or ( ls.interest_amount <> if(ls.accrual_interest_derived
is null,0,ls.accrual_interest_derived)))")
    -                .append("  and loan.loan_status_id=? and mpl.accounting_type=? and loan.is_npa=0
and ls.duedate <= CURDATE() order by loan.id,ls.duedate");
    -        return this.jdbcTemplate.query(sqlBuilder.toString(), mapper, new Object[] {
LoanStatus.ACTIVE.getValue(),
    -                AccountingRuleType.ACCRUAL_PERIODIC.getValue() });
    +                .append(" and ls.duedate > :organisationstartdate and loan.loan_status_id=:active
and mpl.accounting_type=:type and loan.is_npa=0 and ls.duedate <= CURDATE() order by loan.id,ls.duedate");
    +        Map<String, Object> paramMap = new HashMap<>(3);
    +        paramMap.put("active", LoanStatus.ACTIVE.getValue());
    +        paramMap.put("type", AccountingRuleType.ACCRUAL_PERIODIC.getValue());
    +        paramMap.put("organisationstartdate", formatter.print(new LocalDate(organisationStartDate)));
    --- End diff --
    
    what happens when organisationStartDate is disabled?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message