fineract-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rajuan <...@git.apache.org>
Subject [GitHub] incubator-fineract pull request: adding organisation start in glob...
Date Mon, 29 Feb 2016 04:20:58 GMT
Github user rajuan commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/12#discussion_r54368112
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/data/GlobalConfigurationDataValidator.java
---
    @@ -71,6 +73,11 @@ public void validateForUpdate(final JsonCommand command) {
                 final Long valueStr = this.fromApiJsonHelper.extractLongNamed(VALUE, element);
                 baseDataValidator.reset().parameter(ENABLED).value(valueStr).zeroOrPositiveAmount();
             }
    +        
    +        if (this.fromApiJsonHelper.parameterExists(DATE_VALUE, element)) {
    +            final LocalDate dateValue = this.fromApiJsonHelper.extractLocalDateNamed(DATE_VALUE,
element);
    +            baseDataValidator.reset().parameter(DATE_VALUE).value(dateValue).ignoreIfNull();
    --- End diff --
    
    Nothing is being validated? looks like missing validation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message