fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract-cn-mobile] varsvat commented on a change in pull request #169: Fix-303: Image select from Gallery Downloads crash fixed
Date Mon, 22 Mar 2021 07:40:34 GMT

varsvat commented on a change in pull request #169:
URL: https://github.com/apache/fineract-cn-mobile/pull/169#discussion_r598481286



##########
File path: app/src/main/java/org/apache/fineract/utils/FileUtils.java
##########
@@ -224,7 +248,7 @@ public static void writeInputStreamDataToFile(InputStream in, File file)
{
             out.close();
             in.close();
         } catch (Exception e) {
-            Log.d(LOG_TAG, e.getLocalizedMessage());
+            Logger.getLogger(e.getLocalizedMessage());

Review comment:
       you didn't get me . What I am trying to say is don't fix 2 issues in a single PR like
you are getting the issue of pmd error with LOG, then update this in a diff. PR or ask this
on the IRC channel . The use of Logger might be beneficial , just don't update two things
at the same time. Also , when some newbie goes thorough your PR, he won't understand why is
this Log been replaced with Logger in this particular PR. This modification isn't related
to this issue, right ? I hope that makes sense :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message