From commits-return-13297-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Wed Nov 18 23:04:39 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 8B6CA18063D for ; Thu, 19 Nov 2020 00:04:39 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id E377B67CAD for ; Wed, 18 Nov 2020 23:04:38 +0000 (UTC) Received: (qmail 51796 invoked by uid 500); 18 Nov 2020 23:04:38 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 51787 invoked by uid 99); 18 Nov 2020 23:04:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Nov 2020 23:04:38 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_a_change_in_pul?= =?utf-8?q?l_request_=231501=3A_README_update_for_WAR_file?= Message-ID: <160574067805.15632.7969136099439836807.asfpy@gitbox.apache.org> Date: Wed, 18 Nov 2020 23:04:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: vorburger commented on a change in pull request #1501: URL: https://github.com/apache/fineract/pull/1501#discussion_r526477028 ########## File path: README.md ########## @@ -59,7 +59,7 @@ The tenants database connection details are configured [via environment variable Instructions to build a WAR file ============ 1. Clone the repository or download and extract the archive file to your local directory. -2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `build/libs` directory. +2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `fineract-provider/build/libs` directory. 3. Deploy this WAR to your Tomcat v9 Servlet Container. We recommend using the JAR instead of the WAR file deployment, because it's much easier. Review comment: I don't recommend that you configure the SSL certificate at all... :smile: E.g. on https://www.fineract.dev I actually do not do that! You ask how it works :smiling_imp: then? It's now documented on https://github.com/apache/fineract/pull/1503, waiting for your review... :smile: This PR LGTM as is, to me; I wouldn't change this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org