From commits-return-13178-archive-asf-public=cust-asf.ponee.io@fineract.apache.org  Tue Nov  3 13:29:51 2020
Return-Path: <commits-return-13178-archive-asf-public=cust-asf.ponee.io@fineract.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37])
	by mx-eu-01.ponee.io (Postfix) with ESMTPS id 9765F18064E
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  3 Nov 2020 14:29:51 +0100 (CET)
Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153])
	by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 0DFE86489A
	for <archive-asf-public@cust-asf.ponee.io>; Tue,  3 Nov 2020 13:29:46 +0000 (UTC)
Received: (qmail 77739 invoked by uid 500); 3 Nov 2020 13:29:46 -0000
Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@fineract.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@fineract.apache.org>
List-Post: <mailto:commits@fineract.apache.org>
List-Id: <commits.fineract.apache.org>
Reply-To: dev@fineract.apache.org
Delivered-To: mailing list commits@fineract.apache.org
Received: (qmail 77730 invoked by uid 99); 3 Nov 2020 13:29:46 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Nov 2020 13:29:46 +0000
From: =?utf-8?q?GitBox?= <git@apache.org>
To: commits@fineract.apache.org
Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_a_change_in_pul?=
 =?utf-8?q?l_request_=231486=3A_Bump_ancient_OkHTTP_=26_Retrofit_in_Hooks_?=
 =?utf-8?q?=28FINERACT-1252=29?=
Message-ID: <160441018620.15632.3966652615434990469.asfpy@gitbox.apache.org>
Date: Tue, 03 Nov 2020 13:29:46 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
References: <fineract.1486.MDExOlB1bGxSZXF1ZXN0NTEzNjM0ODgx.gitbox@gitbox.apache.org>
In-Reply-To: <fineract.1486.MDExOlB1bGxSZXF1ZXN0NTEzNjM0ODgx.gitbox@gitbox.apache.org>


vorburger commented on a change in pull request #1486:
URL: https://github.com/apache/fineract/pull/1486#discussion_r516484425



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/service/HookWritePlatformServiceJpaRepositoryImpl.java
##########
@@ -282,15 +282,10 @@ private void validateHookRules(final HookTemplate template, final Set<HookConfig
             if (conf.getFieldName().equals(payloadURLName)) {
                 try {
                     final WebHookService service = processorHelper.createWebHookService(fieldValue);
-                    service.sendEmptyRequest();
-                } catch (RetrofitError re) {
-                    // Swallow error if it's because of method not supported or
-                    // if url throws 404 - required for integration test,
-                    // url generated on 1st POST request
-                    if (re.getResponse() == null) {
-                        String errorMessage = "url.invalid";
-                        baseDataValidator.reset().failWithCodeNoParameterAddedToErrorCode(errorMessage);
-                    }
+                    service.sendEmptyRequest().execute();
+                } catch (IOException re) {
+                    String errorMessage = "url.invalid";

Review comment:
       I was also wondering, but the integration tests all still pass now, so looks like this actually wasn't needed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org