fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #1368: Improve error handling if reporting service implementation is missing [FINERACT-1173]
Date Sat, 21 Nov 2020 20:44:41 GMT

vorburger commented on pull request #1368:
URL: https://github.com/apache/fineract/pull/1368#issuecomment-731634175


   @ptuomola re-review this, better now? @vidakovic do you also want to co-pair-review this?
Let's give Petri a chance to look it over, so don't merge, just LGTM; this one is a big enough
change to warrant 4 extra eyes.. this was supposed to be "just adding a check" but turned
into a fairly big refactoring! :smile: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message