fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1501: README update for WAR file
Date Wed, 18 Nov 2020 23:04:38 GMT

vorburger commented on a change in pull request #1501:
URL: https://github.com/apache/fineract/pull/1501#discussion_r526477028



##########
File path: README.md
##########
@@ -59,7 +59,7 @@ The tenants database connection details are configured [via environment
variable
 Instructions to build a WAR file
 ============
 1. Clone the repository or download and extract the archive file to your local directory.
-2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `build/libs`
directory.
+2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `fineract-provider/build/libs`
directory.
 3. Deploy this WAR to your Tomcat v9 Servlet Container.
 
 We recommend using the JAR instead of the WAR file deployment, because it's much easier.

Review comment:
       I don't recommend that you configure the SSL certificate at all... :smile: E.g. on
https://www.fineract.dev I actually do not do that! You ask how it works :smiling_imp: then?
It's now documented on https://github.com/apache/fineract/pull/1503, waiting for your review...
:smile: This PR LGTM as is, to me; I wouldn't change this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message