fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1404: FINERACT-1203: Fix broken Executable WAR
Date Wed, 18 Nov 2020 13:13:59 GMT

vorburger commented on a change in pull request #1404:
URL: https://github.com/apache/fineract/pull/1404#discussion_r526076462



##########
File path: README.md
##########
@@ -59,7 +59,7 @@ The tenants database connection details are configured [via environment
variable
 Instructions to build a WAR file
 ============
 1. Clone the repository or download and extract the archive file to your local directory.
-2. Run `./gradlew clean bootWar` to build a traditional WAR file which will be created at
`build/libs` directory.
+2. Run `./gradlew clean war` to build a traditional WAR file which will be created at `build/libs`
directory.

Review comment:
       Let's please discuss this further only on the comments in FINERACT-1203 instead of
in 3 places.

##########
File path: fineract-provider/build.gradle
##########
@@ -725,13 +725,12 @@ springBoot {
     mainClassName = 'org.apache.fineract.ServerApplication'
 }
 
-bootWar {
-    mainClassName = 'org.apache.fineract.ServerApplication'
+bootJar {
     duplicatesStrategy = DuplicatesStrategy.EXCLUDE
 }
 
-bootJar {
-    duplicatesStrategy = DuplicatesStrategy.EXCLUDE
+bootWar {
+    enabled = false

Review comment:
       Let's please discuss this further only on the comments in FINERACT-1203 instead of
in 3 places.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message