fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] avikganguly01 commented on a change in pull request #1404: FINERACT-1203: Fix broken Executable WAR
Date Wed, 18 Nov 2020 12:46:21 GMT

avikganguly01 commented on a change in pull request #1404:
URL: https://github.com/apache/fineract/pull/1404#discussion_r526058981



##########
File path: fineract-provider/build.gradle
##########
@@ -725,13 +725,12 @@ springBoot {
     mainClassName = 'org.apache.fineract.ServerApplication'
 }
 
-bootWar {
-    mainClassName = 'org.apache.fineract.ServerApplication'
+bootJar {
     duplicatesStrategy = DuplicatesStrategy.EXCLUDE
 }
 
-bootJar {
-    duplicatesStrategy = DuplicatesStrategy.EXCLUDE
+bootWar {
+    enabled = false

Review comment:
       @ptuomola @vidakovic @vorburger Build is successful with bootWar as well but WAR file
is not generated in build/libs. 
   > Task : bootWar SKIPPED
   Flipped enabled of bootWar to true and re-ran the command to generate WAR file. File size
is 100mb against v1.4's ~70mb. 
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message