fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #1485: ContentRepository.fetchImage() FileData not ImageData (FINERACT-1201)
Date Tue, 17 Nov 2020 21:08:46 GMT

vorburger commented on pull request #1485:
URL: https://github.com/apache/fineract/pull/1485#issuecomment-729214908


   @ptuomola @vidakovic @percyashu @xurror @fynmanoj @avikganguly01 @vincent-fuchs @awasum
any of you willing to review this, for FINERACT-1201? Once this is in, a few more such refactoring
may be proposed, and ultimately I will then work on FINERACT-955 some day.
   
   I'm reasonable confident that this won't break break any :smiling_face_with_three_hearts:
the documents and images features, because in FINERACT-1218 I have contributed [new test coverage
for all this stuff](https://github.com/apache/fineract/tree/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/client)
(and since FINERACT-1209 those new tests DO actually run in our CI!), but of course careful
human code review is always still a good idea... :smiling_imp: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message