fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] avikganguly01 commented on a change in pull request #1486: Bump ancient OkHTTP & Retrofit in Hooks (FINERACT-1252)
Date Tue, 03 Nov 2020 13:37:48 GMT

avikganguly01 commented on a change in pull request #1486:
URL: https://github.com/apache/fineract/pull/1486#discussion_r516501351



##########
File path: integration-tests/src/test/java/org/apache/fineract/integrationtests/HookIntegrationTest.java
##########
@@ -98,12 +93,11 @@ public void shouldSendOfficeCreationNotification() {
         } finally {
             this.hookHelper.deleteHook(hookId.longValue());
         }
-
     }
 
     @Test
     public void createUpdateAndDeleteHook() {
-        final String payloadURL = "http://echo-webhook.herokuapp.com:80/Z7RXoCBdLSFMDrpn?";
+        final String payloadURL = "http://echo-webhook.herokuapp.com:80/Z7RXoCBdLSFMDrpn/";

Review comment:
       Weird host this Heroku URL is failing in Postman with trailing / but working in Retrofit
with trailing /.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message