From commits-return-13079-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Fri Oct 23 20:55:53 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 4547518064E for ; Fri, 23 Oct 2020 22:55:53 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 8561443837 for ; Fri, 23 Oct 2020 20:55:52 +0000 (UTC) Received: (qmail 21626 invoked by uid 500); 23 Oct 2020 20:55:52 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 21617 invoked by uid 99); 23 Oct 2020 20:55:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Oct 2020 20:55:52 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_awasum_commented_on_pull_request_=2311?= =?utf-8?q?79=3A_FINERACT-826_Migrate_to_java=2Etime_from_Joda_API?= Message-ID: <160348655218.32230.3111666902042499247.asfpy@gitbox.apache.org> Date: Fri, 23 Oct 2020 20:55:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: awasum commented on pull request #1179: URL: https://github.com/apache/fineract/pull/1179#issuecomment-715585625 @ptuomola and @vorburger . Thanks for reviewing. I will take a closer look tomorrow and probably merge this one. This is great work @percyashu . Do we need to write and inform the rest of the community on the mailing list? (I think its worth it, this is massive). Next is to handle https://issues.apache.org/jira/browse/FINERACT-1112 as a follow up to this. Anyone going to handle that one after this is merged? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org