From commits-return-13013-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Wed Oct 21 13:11:50 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id C41ED18063B for ; Wed, 21 Oct 2020 15:11:50 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 06972123482 for ; Wed, 21 Oct 2020 13:11:50 +0000 (UTC) Received: (qmail 91176 invoked by uid 500); 21 Oct 2020 13:11:49 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 91167 invoked by uid 99); 21 Oct 2020 13:11:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Oct 2020 13:11:49 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_ptuomola_commented_on_pull_request_=23?= =?utf-8?q?1456=3A_Fix_possible_NPE_when_uploading_Documents_=26_Images_=28F?= =?utf-8?q?INERACT-1036=29?= Message-ID: <160328590963.32230.3360347144282105978.asfpy@gitbox.apache.org> Date: Wed, 21 Oct 2020 13:11:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: ptuomola commented on pull request #1456: URL: https://github.com/apache/fineract/pull/1456#issuecomment-713558444 @vorburger wow that ended up being a lot bigger change than the 4 lines of code I expected! What was your thinking around changing the variables from specific types to var? I suppose the same change could be applied to pretty much any line of code in Fineract... :-) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org