From commits-return-12664-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Tue Oct 13 23:18:49 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 3C8AF18060E for ; Wed, 14 Oct 2020 01:18:49 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 97490638F8 for ; Tue, 13 Oct 2020 23:18:48 +0000 (UTC) Received: (qmail 40701 invoked by uid 500); 13 Oct 2020 23:18:47 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 40692 invoked by uid 99); 13 Oct 2020 23:18:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2020 23:18:47 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_pull_request_?= =?utf-8?q?=231396=3A_FINERACT-1188=3A_README_and_other_files_are_not_covere?= =?utf-8?q?d_by_Spotless?= Message-ID: <160263112779.32230.9895186955850209188.asfpy@gitbox.apache.org> Date: Tue, 13 Oct 2020 23:18:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: vorburger commented on pull request #1396: URL: https://github.com/apache/fineract/pull/1396#issuecomment-708060695 @vidakovic Whoa! Nice. I'll review ASAP, but 1 quick minor practical feedback already: If you change the usual merge drop-down (above) to the _Rebase and merge_ which we typically prefer using (see https://github.com/apache/fineract#merge-strategy), you'll see that GitHub shows _This branch cannot be rebased due to conflicts_. That means we would HAVE to merge your 2 commits here with _Create a merge commit_, which is possible, but always a bit "ugly" and we try to avoid, or with _Squash and merge_ and that creates weird author/ownership metadata (check out e.g. latest e57b7da). If you don't mind, just do a `git rebase develop` (fixing anything required), and `git push --force vidakovic`, and it will be a little bit "cleaner". With that out of the way, I'll review the actual changes now! :smiling_imp: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org