From commits-return-12403-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Sat Oct 3 21:13:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 6454918063F for ; Sat, 3 Oct 2020 23:13:31 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id CC3F26397B for ; Sat, 3 Oct 2020 21:13:30 +0000 (UTC) Received: (qmail 39942 invoked by uid 500); 3 Oct 2020 21:13:30 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 39933 invoked by uid 99); 3 Oct 2020 21:13:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Oct 2020 21:13:30 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_vorburger_commented_on_pull_request_?= =?utf-8?q?=231366=3A_FINERACT-982_-_Completely_ditch_use_of_Drizzle_JDBC_Dr?= =?utf-8?q?iver?= Message-ID: <160175961000.32230.6113576311958448102.asfpy@gitbox.apache.org> Date: Sat, 03 Oct 2020 21:13:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: vorburger commented on pull request #1366: URL: https://github.com/apache/fineract/pull/1366#issuecomment-703165480 > Not sure if that applies also for running unit tests on the console, would need to test. So for `./gradlew integrationTest` to work with what I have proposed above, where I suggest that we do NOT include any JDBC driver JAR into the WAR, we would just have to add it (a JDBC driver) to the external Tomcat which we start for running the ITs. This, hopefully, shouldn't actually be that hard - note the [`extraClasspath` and `sharedClasspath` properties](https://github.com/bmuschko/gradle-cargo-plugin#extension-properties), which we should be able to use somewhere in [our Cargo plugin configuration](https://github.com/apache/fineract/blob/develop/fineract-provider/build.gradle#L682)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org