fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vidakovic opened a new pull request #1422: FINERACT-1210: Swagger TypeScript client
Date Sat, 17 Oct 2020 21:30:35 GMT

vidakovic opened a new pull request #1422:
URL: https://github.com/apache/fineract/pull/1422


   ## Description
   
   I've chosen the Angular Typescript flavor, because I think it'll be one of the more common
choices out there. But there are quite some options available for Typescript; see here (and
search for "typescript"): https://openapi-generator.tech/docs/generators/
   In terms of configuration I didn't do actually too much here. I suggest you build it yourself
and look in fineract-client/build/generated/typescript for the result. A first look at it
seems OK to me (e. g. dependencies in package.json seem reasonable and minimal for Angular).
   
   ## Checklist
   
   - [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_
- it is your responsibility to get a proposed PR to pass the build, not primarily the project's
maintainers.
   
   - [x] Create/update unit or integration tests for verifying the changes made.
   
   - [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm
with details of any API changes
   
   - [x] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the developer mailing list for guidance, if required.)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message