fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vidakovic opened a new pull request #1417: FINERACT-1102: Swagger Codegen Client JAR should be available on a Ma…
Date Sat, 17 Oct 2020 19:27:58 GMT

vidakovic opened a new pull request #1417:
URL: https://github.com/apache/fineract/pull/1417


   ## Description
   
   The following things need to be solved before the publishing can work:
   
   1. It's probably best to create an account at https://bintray.com. They make publishing
on Maven Central so much easier.
   2. We need to upload a GPG signing key to Bintray once we have an account.
   3. We will also need a user token from Sonatype to be able to publish to Maven Central.
Details see here: https://stackoverflow.com/questions/38294001/how-to-sync-from-bintray-to-maven-central-without-knowing-maven
   4. We have to decide if we want to list any developers in the generated pom.xml that gets
published. There is a TODO in the root build.gradle
   5. I've created the Maven publish configuration already in a way so that it can be applied
to multiple modules without major edits. Note: next one to publish will be fineract-api.
   6. There's a sample configuration to show how publishing on Github Packages would work.
This just FYI and will be removed once we are done here. I think Maven Central is the best
choice.
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_
- it is your responsibility to get a proposed PR to pass the build, not primarily the project's
maintainers.
   
   - [x] Create/update unit or integration tests for verifying the changes made.
   
   - [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm
with details of any API changes
   
   - [x] Submission is not a "code dump".  (Large changes can be made "in repository" via
a branch.  Ask on the developer mailing list for guidance, if required.)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message