fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vidakovic commented on pull request #1444: Introduce first "pure Spring" integration test, without Cargo (FINERACT-764)
Date Tue, 27 Oct 2020 10:17:18 GMT

vidakovic commented on pull request #1444:
URL: https://github.com/apache/fineract/pull/1444#issuecomment-717137108


   > @ptuomola @vidakovic I'm undecided / unclear where we should take this to.. thoughts?
I guess we could... EITHER (probably best AFTER #1465 will have gone in):
   > 
   > a) move towards entirely ditching the Cargo plugin and not start the WAR but just
use this new style to fire up Spring "in-process" for (all) ITs
   
   a) I'd prefer to go that way. The Cargo plugin requires the WAR artifact and is in the
end an external process... just to say: a lot of moving parts to take care of. During a normal
build it maybe doesn't make much of a difference for devs, but if you execute e. g. "./gradlew
:integration-tests:test" then Cargo doesn't shutdown for some reason and leaves a zombie process
(just found that out yesterday). And I have a hunch that Spring tests would run faster.
   
   > b) forget about this approach and abandon this PR and just close [FINERACT-764](https://issues.apache.org/jira/browse/FINERACT-764)
(I don't actually really mind either)
   > 
   > c) have some mixed form - keep testing the WAR with the Cargo plugin for some basic
tests, but move other ITs to this style.
   
   c) Realistically, we will probably take a moment or two to refactor all integration tests.
So for a while we would be probably running in a "hybrid" mode. Maybe we could do this migration
together with moving towards Fineract Client usage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message