fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] nikpawar89 commented on a change in pull request #1361: FINERACT-1169 fixed credit bureau Loan-product mapping module
Date Tue, 27 Oct 2020 02:02:20 GMT

nikpawar89 commented on a change in pull request #1361:
URL: https://github.com/apache/fineract/pull/1361#discussion_r512371367



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/data/CreditBureauLoanProductMappingData.java
##########
@@ -104,7 +104,7 @@ public long getStalePeriod() {
         return this.stalePeriod;
     }
 
-    public boolean isisActive() {
+    public boolean isIs_active() {

Review comment:
       isActive() should be sufficient

##########
File path: fineract-provider/src/main/resources/sql/migrations/core_db/V327__creditbureau_configuration.sql
##########
@@ -66,7 +66,7 @@ CREATE TABLE `m_creditbureau_loanproduct_mapping` (
   `is_creditcheck_mandatory` tinyint DEFAULT NULL,
   `skip_creditcheck_in_failure` tinyint DEFAULT NULL,
   `stale_period` INT DEFAULT NULL,
-  `is_active` tinyint DEFAULT NULL,
+  `isActive` tinyint DEFAULT NULL,

Review comment:
       I think you should create a new migration script. But as this is develop can we get
away with just fixing the script. 
   Any thoughts @vorburger 

##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/OrganisationCreditBureauWritePlatflormServiceImpl.java
##########
@@ -76,13 +76,13 @@ public CommandProcessingResult updateCreditBureau(JsonCommand command)
{
 
         final long creditbureauID = command.longValueOfParameterNamed("creditBureauId");
 
-        final boolean is_active = command.booleanPrimitiveValueOfParameterNamed("is_active");
+        final boolean isActive = command.booleanPrimitiveValueOfParameterNamed("isActive");
 
         final OrganisationCreditBureau orgcb = organisationCreditBureauRepository.getOne(creditbureauID);
 
-        orgcb.setIsActive(is_active);
+        orgcb.setIsActive(isActive);
 
-        organisationCreditBureauRepository.saveAndFlush(orgcb);

Review comment:
       you do not want to commit to transaction?

##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/data/CreditBureauLoanProductMappingData.java
##########
@@ -104,7 +104,7 @@ public long getStalePeriod() {
         return this.stalePeriod;
     }
 
-    public boolean isisActive() {
+    public boolean isIs_active() {

Review comment:
       just isActive shoud be fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message