fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] awasum commented on a change in pull request #1444: Introduce first "pure Spring" integration test, without Cargo (FINERACT-764)
Date Mon, 26 Oct 2020 09:25:09 GMT

awasum commented on a change in pull request #1444:
URL: https://github.com/apache/fineract/pull/1444#discussion_r511819200



##########
File path: fineract-provider/src/test/java/org/apache/fineract/common/RestAssuredFixture.java
##########
@@ -34,14 +34,12 @@
 
     private final int httpPort;
 
-    private ResponseSpecification responseSpec;
-    private RequestSpecification requestSpec;
+    private final ResponseSpecification responseSpec;
+    private final RequestSpecification requestSpec;
 
-    public RestAssuredFixture(int http) {
-
-        this.httpPort = http;
+    public RestAssuredFixture() {
+        this.httpPort = 844;

Review comment:
       @vorburger Just curious and catching up to all the brilliant development done the past
few weeks. Is this suppose to be port: 8443? or something new which I dont understand? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message