fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1466: FINERACT-1241-elastic-web-hook
Date Sun, 25 Oct 2020 18:49:59 GMT

vorburger commented on a change in pull request #1466:
URL: https://github.com/apache/fineract/pull/1466#discussion_r511633803



##########
File path: fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java
##########
@@ -37,6 +44,9 @@
 import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
 import org.apache.fineract.useradministration.domain.AppUser;
 import org.joda.time.DateTime;
+import org.joda.time.DateTimeZone;

Review comment:
       Joda Time support has just been removed.. use java.time.

##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/processor/ProcessorHelper.java
##########
@@ -121,4 +121,20 @@ public WebHookService createWebHookService(final String url) {
         final RestAdapter restAdapter = new RestAdapter.Builder().setEndpoint(url).setClient(new
OkClient(client)).build();
         return restAdapter.create(WebHookService.class);
     }
+
+    public Callback createCallback(final String url, String payload) {
+
+        return new Callback() {
+
+            @Override
+            public void success(final Object o, final Response response) {
+                LOG.info("URL : {} \tStatus : {}", url, response.getStatus());
+            }
+
+            @Override
+            public void failure(final RetrofitError retrofitError) {
+                LOG.info("{}", retrofitError.getMessage());

Review comment:
       LOG.error() is probably better here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message