fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on a change in pull request #1418: FINERACT-1207: Clean up fineract-provider/config/swagger following in…
Date Mon, 19 Oct 2020 18:15:36 GMT

ptuomola commented on a change in pull request #1418:
URL: https://github.com/apache/fineract/pull/1418#discussion_r507965774



##########
File path: fineract-provider/build.gradle
##########
@@ -600,21 +600,3 @@ gitProperties {
 
 // make sure the generateGitProperties task always executes (even when git.properties is
not changed)
 generateGitProperties.outputs.upToDateWhen { false }
-
-task prepareConfigJson(dependsOn: 'generateGitProperties') {

Review comment:
       Yes - this should be OK - the Swagger UI should only depend on the index.html that
has been checked in, not on this config.json file. As far as I recall this is only used for
the code generator...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message