fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vidakovic edited a comment on pull request #1422: FINERACT-1210: Swagger TypeScript client
Date Sun, 18 Oct 2020 02:02:02 GMT

vidakovic edited a comment on pull request #1422:
URL: https://github.com/apache/fineract/pull/1422#issuecomment-711105429


   @vorburger I would say the only thing maybe missing in this context is to publish the NPM
package. I am wondering if we can use Apache's Nexus for that. Nexus supports NPM packages
(and Docker images for that matter); the question is only if we can use those services. If
not we have to figure out  how to publish to NPM. I think we can do this in a separate PR.
   
   I agree that we should show how this code is supposed to be used. Not sure how much code
needs to be shown to make the basics work; for the description in "client.md" I would limit
it to the bare minimum and just put a reference to a sample implementation.
   
   I don't think this repo here is the best place for a full sample implementation. I think
this would fit better in a separate Git repository or as part of one of the more current Fineract
web UI projects (not sure which one uses a more recent version of Angular).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message