fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #1415: Update dependency org.threeten:threetenbp to v1.4.5
Date Sat, 17 Oct 2020 18:53:32 GMT

ptuomola commented on pull request #1415:
URL: https://github.com/apache/fineract/pull/1415#issuecomment-711064546


   If you look in
   https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/java.md,
   it seems this library is not needed, given we are setting dateLibrary as
   java8
   
   In general the list of dependencies for the client seems very extensive -
   do we really need all of these...
   
   
   
   On Sat, 17 Oct 2020, 9:20 pm Aleksandar Vidakovic, <notifications@github.com>
   wrote:
   
   > I quickly tried this quickly in #1416
   > <https://github.com/apache/fineract/pull/1416>. I think we can remove
   > that dependency; no complaints with integration tests. FYI
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fineract/pull/1415#issuecomment-711060618>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AASJVCUJDD4ULWYGMDGQY3TSLHOATANCNFSM4SUPDILA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message