fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1402: FINERACT-1189: fineract client as a separate module
Date Thu, 15 Oct 2020 12:12:40 GMT

vorburger commented on a change in pull request #1402:
URL: https://github.com/apache/fineract/pull/1402#discussion_r505489277



##########
File path: build.gradle
##########
@@ -20,6 +20,16 @@
 buildscript {
     ext {
         jacocoVersion = '0.8.5'
+        retrofitVersion = '2.9.0'
+        okhttpVersion = '4.7.2'
+        oltuVersion = '1.0.1'

Review comment:
       This seems curious, to me.. isn't this RUNTIME related, not BUILD time? Why is e.g.
okhttp required to generate code? There's probably a good reason. But we didn't seem to have
it before, so I thought I could ask.

##########
File path: .travis.yml
##########
@@ -72,6 +72,6 @@ script:
 # using "&&" instead of several "-" means that integrationTest does not run if test
fails,
 # and Docker test does not run if integration test fails, which makes PR failure easier to
understand.
 # @see https://docs.travis-ci.com/user/job-lifecycle/#customizing-the-build-phase
-  - ./gradlew --console=plain -PautomatedBuild=true licenseMain licenseTest licenseIntegrationTest
check  &&  ./gradlew --console=plain -PautomatedBuild=true integrationTest --fail-fast
 &&  sudo service mysql stop  &&  docker-compose build  &&  docker-compose
up -d  &&  sleep 60s  && curl -f -k --retry 5 --retry-connrefused --connect-timeout
30 --retry-delay 30 https://localhost:8443/fineract-provider/actuator/health  && 
(( $(curl -f -k --retry 5 --retry-connrefused --connect-timeout 30 --retry-delay 30 https://localhost:8443/fineract-provider/actuator/info
| wc --chars) > 100 )) && ./gradlew generateSwaggerCode && cd fineract-provider/build/swagger-code-fineract
&& mvn test
+  - ./gradlew --console=plain -PautomatedBuild=true licenseMain licenseTest licenseIntegrationTest
check  &&  ./gradlew --console=plain -PautomatedBuild=true integrationTest --fail-fast
 &&  sudo service mysql stop  &&  docker-compose build  &&  docker-compose
up -d  &&  sleep 60s  && curl -f -k --retry 5 --retry-connrefused --connect-timeout
30 --retry-delay 30 https://localhost:8443/fineract-provider/actuator/health  && 
(( $(curl -f -k --retry 5 --retry-connrefused --connect-timeout 30 --retry-delay 30 https://localhost:8443/fineract-provider/actuator/info
| wc --chars) > 100 ))

Review comment:
       How does Travis cover for the client now? Just curious.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message