fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1396: FINERACT-1188: README and other files are not covered by Spotless
Date Tue, 13 Oct 2020 23:29:31 GMT

vorburger commented on a change in pull request #1396:
URL: https://github.com/apache/fineract/pull/1396#discussion_r504315547



##########
File path: fineract-provider/build.gradle
##########
@@ -179,13 +136,6 @@ if (project.hasProperty('env') && project.getProperty('env')
== 'eclipse')
     sourceSets.main.java.outputDir = new File(rootProject.projectDir, "fineract-provider/bin/main")
 }
 
-eclipse
-{
-    project {
-        buildCommand([ LaunchConfigHandle: "<project>/.externalToolBuilders/OpenJPA
Enhance Builder.launch" ],  'org.eclipse.ui.externaltools.ExternalToolBuilder')

Review comment:
       so this gets entirely ditch, not just moved.. why? @ptuomola does this LGTY? (I have
NOT pulled it myself yet, to actually test.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message