fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vidakovic commented on a change in pull request #1396: FINERACT-1188: README and other files are not covered by Spotless
Date Tue, 13 Oct 2020 18:43:57 GMT

vidakovic commented on a change in pull request #1396:
URL: https://github.com/apache/fineract/pull/1396#discussion_r504177028



##########
File path: fineract-provider/build.gradle
##########
@@ -688,6 +582,12 @@ dependencies {
 cargo {
     containerId "tomcat9x"
 
+    // looks like Cargo doesn't detect the WAR file automatically in the multi-module setup
+    deployable {
+        file = file("${buildDir}/libs/fineract-provider-${releaseVersion}.war")
+        context = 'fineract-provider'

Review comment:
       I was not aware of that change... that's all. If you say that this is already working
in develop then I have to pull in the recent changes; that's all.
   
   Is FINERACT-1187 already merged? I just checked upstream... there are no changes that anyone
took care of FINERACT-1187... will do this now... just to get this thing over the finish line.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message