fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1396: FINERACT-1188: README and other files are not covered by Spotless
Date Tue, 13 Oct 2020 18:36:01 GMT

vorburger commented on a change in pull request #1396:
URL: https://github.com/apache/fineract/pull/1396#discussion_r504174907



##########
File path: fineract-provider/build.gradle
##########
@@ -688,6 +582,12 @@ dependencies {
 cargo {
     containerId "tomcat9x"
 
+    // looks like Cargo doesn't detect the WAR file automatically in the multi-module setup
+    deployable {
+        file = file("${buildDir}/libs/fineract-provider-${releaseVersion}.war")
+        context = 'fineract-provider'

Review comment:
       But wouldn't that be a "regression" of FINERACT-1187? Why do we have to break that
here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message