fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on a change in pull request #1396: FINERACT-1188: README and other files are not covered by Spotless
Date Tue, 13 Oct 2020 18:35:28 GMT

ptuomola commented on a change in pull request #1396:
URL: https://github.com/apache/fineract/pull/1396#discussion_r504174570



##########
File path: fineract-provider/build.gradle
##########
@@ -688,6 +582,12 @@ dependencies {
 cargo {
     containerId "tomcat9x"
 
+    // looks like Cargo doesn't detect the WAR file automatically in the multi-module setup
+    deployable {
+        file = file("${buildDir}/libs/fineract-provider-${releaseVersion}.war")
+        context = 'fineract-provider'

Review comment:
       Hmm... not sure I understand. After FINERACT-1187 was merged 4 days ago, we were building
fineract-provider.war. Are you saying that some other change has now broken that again, and
we are back to building fineract-provider-releaseVersion.war? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message