fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [fineract] vidakovic edited a comment on pull request #1381: FINERACT-1188: README and other files are not covered by Spotless
Date Sun, 11 Oct 2020 22:50:21 GMT

vidakovic edited a comment on pull request #1381:

   @vorburger @ptuomola So, I think that would be it... the only thing: I had some difficulties
rebasing that's why you see multiple commits. When I pulled in the latest changes from upstream
I had to solve one conflict. During rebase I ran then multiple times into various conflict
situations and didn't really entirely understand why. But the Spotless configuration is now
moved to the root build.gradle and will work for any module that is added (not only for fineract-provider).
I've removed also everything that's unnecessary in fineract-provider (mostly Spotless related).
@vorburger as you can see the changes are inline and not externalized with "apply from" etc.
   I just don't know why the CI build is failing again. Don't really see a reason why that
health check would fail. Any ideas?

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message