fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #1388: FINERACT-1194: Move Gradle wrapper to root folder
Date Sun, 11 Oct 2020 16:46:42 GMT

ptuomola commented on pull request #1388:
URL: https://github.com/apache/fineract/pull/1388#issuecomment-706733115


   Well... I'm personally very interested in ensuring Eclipse continues to work, as I use
it a lot! 
   
   I've just looked at this and it's not immediately obvious to me how this can be solved:
   
   The .externalToolBuilders directory should in my view be within fineract-provider, as it
relates only to the fineract-provider subproject, not to any others. The root directory fineract
is not a Eclipse-importable project, only fineract-provider is. 
   
   But if I move it .externalToolBuilders back within fineract-provider, it still needs to
refer to gradlew - which is now outside fineract-provider. And trying to do a relative path
out of fineract-provider doesn't work.
   
   So I'm not quite sure how this will work even with the rest of the changes incorporated.
Maybe I'll take a look at the "full" branch next to see if that has the same problem, or if
it has been resolved there...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message