fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #1388: FINERACT-1194: Move Gradle wrapper to root folder
Date Sun, 11 Oct 2020 15:43:24 GMT

vorburger commented on pull request #1388:
URL: https://github.com/apache/fineract/pull/1388#issuecomment-706723933


   > @vorburger @ptuomola Don't want to be a pain... but could someone of you merge this
please if you have a moment? 
   
   I've LGTM it, but I think it's "fair" to give @ptuomola a chance to review it and LGTM
is as well? Open Source can seem slow...
   
   > Have some free cycles today and would like to proceed with FINERACT-1188
   
   ... but doesn't have to be! What I would do now in such a situation, if I were you, is
to already start to `git rebase` your #1381 on this, and then the latest develop. That way,
you can proceed at least locally. You could even also already push it to GitHub. GitHub is,
unfortunately, a bit too stupid to understand that a PR is continuation of another one (FYI
Gerrit does this MUCH better), but it still unblocks you, and reviewers can look at the N+
separate new commits after the "base" commits from another PR on a new PR;  and it means that
once this PR is merged, even if there are still some small changes requested by another reviewer,
your still ahead and will have an easier time to re-rebase other work that depends on this.
Hope this approach makes sense?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message