fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] ptuomola commented on pull request #1388: FINERACT-1194: Move Gradle wrapper to root folder
Date Sun, 11 Oct 2020 04:13:24 GMT

ptuomola commented on pull request #1388:
URL: https://github.com/apache/fineract/pull/1388#issuecomment-706647138


   Hi @vidakovic - I don't think this is anything specific to Docker, I think the same problem
exists even if you run the build outside docker:
   
   Let's say I've cloned the repository to /Users/ptuomola/Development/apache-fineract/fineract
   
   When I run ./gradlew -PautomatedBuild=true --no-daemon -q -x rat -x test bootJar in that
directory, the JAR file gets created to:
   
   /Users/ptuomola/Development/apache-fineract/fineract/Users/ptuomola/Development/apache-fineract/fineract/build/libs
   
   Looking at your changes in build.gradle, I think $rootDir is being provided as an absolute
path but being treated by gradle as a relative path... 
   
   But I suppose the question is do we even need $rootDir in those places - looks like the
path would be correct if you left it out completely? 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message