fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vidakovic commented on pull request #1381: FINERACT-1188: README and other files are not covered by Spotless
Date Sat, 10 Oct 2020 12:08:20 GMT

vidakovic commented on pull request #1381:
URL: https://github.com/apache/fineract/pull/1381#issuecomment-706539080


   @vorburger to answer your questions:
   
   1.  Just let me know how you and @ptuomola decide... and I'll change it accordingly. I
can see your point here with the non-recurring includes; in general I find those modular gradle
files useful.
   2.  Currently the root wrapper is disabled with the content in settings.gradle. You can't
have 2 wrappers (actually project roots), and as I understood you the goal with that first
PR was not to change anything for existing setups... because if we change this - and I would
really like to do that - then everyone needs to re-import their Gradle project in their IDEs.
If that is OK with everyone I'd be happy to do it.
   3.  See my answer in 2.
   4.  There's no particular reason for -all, just a habit of mine, because with that you
get also Gradle's sources for your IDE. Don't need it that often, but sometimes for debugging
when something is messed up with the Gradle build. Overall you are right, the community probably
won't need it.
   5.  Sure, I can move just the wrapper.
   6.  Done. Approved and merged. Will rebase this branch.
   7.  See my answer in 2. I just wanted to start moving things to the root folder while still
maintaining the same setup for everyone else. I just thought you would find it too invasive.
So again, if everyone is OK re-importing their project from root then I'll happily do that
change.
   
   Concerning squashing: no problem, will do.
   
   Concerning Maven Central: trivial, will appear with the next rounds of cleanups.
   
   Concerning Gradle Plugin Portal: official repo for all Gradle plugins; can't really say
that some might not be available in Maven Central; but could be. Until we really have resolution
errors we can remove.
   
   @vorburger Could you just confirm that those breaking changes are OK before I edit? And
please let me know if you want to see the wrapper move to root in a separate PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message