fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on a change in pull request #1381: FINERACT-1188: README and other files are not covered by Spotless
Date Sat, 10 Oct 2020 09:26:13 GMT

vorburger commented on a change in pull request #1381:
URL: https://github.com/apache/fineract/pull/1381#discussion_r502767019



##########
File path: gradle/repositories.gradle
##########
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+repositories {
+    jcenter()
+    mavenCentral()
+    gradlePluginPortal()

Review comment:
       @vidakovic what is this `gradlePluginPortal()` required for? We don't currently seem
to use it in our `fineract-provider/build.gradle`. If you need it later, it's probably clearer
add it only when it's required, not yet here? But even so.. my Gradle foo is quite limited,
but if anything shouldn't this only be in `buildscript { repositories` and never root `repositories`,
because Gradle Plugins should never be "runtime" dependencies? Is `gradlePluginPortal()` the
equivalent of ``maven { url "https://plugins.gradle.org/m2/" }`?  @ptuomola 

##########
File path: gradle/repositories.gradle
##########
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+repositories {
+    jcenter()
+    mavenCentral()

Review comment:
       @vidakovic if I'm not mistaken, we don't actually need `mavenCentral()`... I'm trying
that out in #1383 (I've always meant to clean that up, but never did).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message