fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] percyashu commented on a change in pull request #1179: FINERACT-826 Migrate to java.time from Joda API
Date Tue, 06 Oct 2020 09:24:01 GMT

percyashu commented on a change in pull request #1179:
URL: https://github.com/apache/fineract/pull/1179#discussion_r500131796



##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/AccountingScenarioIntegrationTest.java
##########
@@ -786,18 +787,18 @@ public void checkPeriodicAccrualAccountingTillCurrentDateFlow() throws
Interrupt
         final ArrayList<HashMap> loanSchedule = this.loanTransactionHelper.getLoanRepaymentSchedule(requestSpec,
responseSpec, loanID);
         // MAKE 1
         List fromDateList = (List) loanSchedule.get(1).get("fromDate");
-        LocalDate fromDateLocal = LocalDate.now();
+        LocalDate fromDateLocal = LocalDate.now(ZoneId.systemDefault());

Review comment:
       It was just a warning from Error Prone that requires one to must  an explicit ZoneId(
whether default). And I think it will be easier to replace ZoneId.systemDefault() with the
tenant's timezone in another PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message