fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] nikpawar89 commented on a change in pull request #1235: FINERACT-734 Creditbureau-Integration-phase3
Date Mon, 05 Oct 2020 03:35:36 GMT

nikpawar89 commented on a change in pull request #1235:
URL: https://github.com/apache/fineract/pull/1235#discussion_r499332023



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/service/CreditReportWritePlatformServiceImpl.java
##########
@@ -95,7 +95,7 @@ public CreditReportWritePlatformServiceImpl(final PlatformSecurityContext
contex
     private static final Logger LOG = LoggerFactory.getLogger(CreditReportWritePlatformServiceImpl.class);
 
     public String httpConnectionMethod(String process, String nrcID, String userName, String
password, String subscriptionKey,
-            String subscriptionId, String url, String token, Long uniqueID) {
+            String subscriptionId, String url, String token, Long uniqueID, File report)
{

Review comment:
       why are we using File in http request




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message