fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #1365: fixed typo : listner -> listener
Date Sat, 03 Oct 2020 14:49:07 GMT

vorburger commented on pull request #1365:
URL: https://github.com/apache/fineract/pull/1365#issuecomment-703115286


   @vincent-fuchs I didn't quite understand what the enum reformatting had to do with the
listner typo fix, but we are ecastic (super excited) to see your interest in this project,
and hope to see more contributions from you, so didn't want to be a pain here and just merge
it anyway (but "squashed" it into 1 single commit; hope you don't mind that?). In the future,
perhaps you would like to raise separate PR in such cases. We prefer several smaller PRs per
specific change, because they are easier for us to code review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message