fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vidakovic commented on pull request #1366: FINERACT-982 - Completely ditch use of Drizzle JDBC Driver
Date Fri, 02 Oct 2020 16:46:07 GMT

vidakovic commented on pull request #1366:
URL: https://github.com/apache/fineract/pull/1366#issuecomment-702839554


   I would externalize all references to specific drivers. What I mean with that is: instead
of hard-coding the driver's class names and connection strings I would replace it with environment
variables. Defaults for those variables would be the Drizzle related settings (for license
compatibility), but anyone running Fineract in production (I guess that's the concern here)
would then overwrite those environment variables either in the docker-compose.yml file or
on the command line. That way no tricks have to be applied during releases and we don't have
to reference the LGPL driver in this repository... which - as much as I understand it - we
actually can't (LGPL being incompatible with Apache License 2)... unless I'm missing anything
here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message