From commits-return-12148-archive-asf-public=cust-asf.ponee.io@fineract.apache.org Mon Sep 21 07:46:54 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 9C4F4180607 for ; Mon, 21 Sep 2020 09:46:54 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id C5C6F1225AC for ; Mon, 21 Sep 2020 07:46:53 +0000 (UTC) Received: (qmail 8749 invoked by uid 500); 21 Sep 2020 07:46:53 -0000 Mailing-List: contact commits-help@fineract.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@fineract.apache.org Delivered-To: mailing list commits@fineract.apache.org Received: (qmail 8740 invoked by uid 99); 21 Sep 2020 07:46:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Sep 2020 07:46:53 +0000 From: =?utf-8?q?GitBox?= To: commits@fineract.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bfineract=5D_thesmallstar_commented_on_a_change_in_?= =?utf-8?q?pull_request_=231290=3A_Added_and_Enforced_AbbreviationAsWordInNa?= =?utf-8?q?me_Checkstyle_=28FINERACT-821=29?= Message-ID: <160067441342.32230.2503603524144796738.asfpy@gitbox.apache.org> Date: Mon, 21 Sep 2020 07:46:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: thesmallstar commented on a change in pull request #1290: URL: https://github.com/apache/fineract/pull/1290#discussion_r491847257 ########## File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/MinimumDaysBetweenDisbursalAndFirstRepaymentTest.java ########## @@ -43,7 +43,7 @@ /** * Test the creation, approval and rejection of a loan reschedule request **/ -@SuppressWarnings({ "rawtypes" }) +@SuppressWarnings({ "rawtypes", "AbbreviationAsWordInName" }) public class MinimumDaysBetweenDisbursalAndFirstRepaymentTest { Review comment: Agreed, Removed. ########## File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/GroupSavingsIntegrationTest.java ########## @@ -160,10 +160,10 @@ public void testSavingsAccount_CLOSE_APPLICATION() { DateFormat dateFormat = new SimpleDateFormat("dd MMMM yyyy", Locale.US); Calendar todaysDate = Calendar.getInstance(); - final String CLOSEDON_DATE = dateFormat.format(todaysDate.getTime()); + final String closedOnDateValue = dateFormat.format(todaysDate.getTime()); String withdrawBalance = "false"; Review comment: updated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org