fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] vorburger commented on pull request #1344: Updated Report-name Regex (FINERACT-1156)
Date Mon, 28 Sep 2020 17:37:59 GMT

vorburger commented on pull request #1344:
URL: https://github.com/apache/fineract/pull/1344#issuecomment-700180249


   > @thesmallstar @vorburger is it possible to merge this so @bharathc27 could test against
fineract.dev
   
   sure, let's just merge this as-is now. @thesmallstar you can add the IT in a follow-up
PR.
   
   > @edcable Let me try to setup community app locally (Somehow it is not working), I
will give an update soon. It will be better if we test and merge this.
   
   @thesmallstar if you have some JS issue, just FYI you could technically use https://cui.fineract.dev
with a `baseApiUrl` to `localhost`. But cui.fineract.dev is not auto updated - watch https://github.com/openMF/community-app/issues/3309
about that.
   
   @vorburger just an idea, can we do something to host a particular branch/PR whenever required
online? It will be so much handy to test the PRs that way, should I make an issue for this?
   
   That's... not that easy. I thought about it as well. But running a server instance costs.
Running a server for every open PR is... non-negligeable. We sure could have some Bot, with
some command, with some timeout that "tears down" per-PR servers, but.. this is a amount of
work I don't have the time for to spend, unfortunately.
   
   However, I think it's acceptable to sometimes merge PRs so that people can test things
on demo.fineract.dev. If things are broken, then follow-up PRs can add further fixes. (The
clean thing to do in theory would actually a PR with a `git revert` and then the proper fix.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message