fineract-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API
Date Thu, 24 Sep 2020 21:53:06 GMT

thesmallstar commented on pull request #1251:
URL: https://github.com/apache/fineract/pull/1251#issuecomment-698608546


   @vorburger @ptuomola @luckyman20 Thank you for waiting a long time for these here is the
update:
   
   1. As mentioned by @ptuomola  for using the implementation ["a","b"] that cannot be really
used here because the request type is not JSON, but we can do something similar.
   2. The API now takes one string and works for both: examples:
                       a. "active"
                       b. "active,approved"
   Example URLS: 
   https://localhost:8443/fineract-provider/api/v1/loans?status=active,approved&tenantIdentifier=default&pretty=true
   
   3. We will merge this now, I will write the Integration tests and I have also made an issue
so that we don't forget to do it. https://issues.apache.org/jira/browse/FINERACT-1160 
   
          
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message